[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <mhng-59817569-7525-450f-9bfd-ecb34a30744c@palmer-ri-x1c9a>
Date: Thu, 11 May 2023 13:53:23 -0700 (PDT)
From: Palmer Dabbelt <palmer@...belt.com>
To: samuel@...lland.org
CC: dmitry.osipenko@...labora.com, rafael.j.wysocki@...el.com,
samuel@...lland.org, aou@...s.berkeley.edu,
apatel@...tanamicro.com, Atish Patra <atishp@...osinc.com>,
geert@...ux-m68k.org, heiko@...ech.de, kai.heng.feng@...onical.com,
mcgrof@...nel.org, paulmck@...nel.org,
Paul Walmsley <paul.walmsley@...ive.com>, pmladek@...e.com,
yuehaibing@...wei.com, linux-kernel@...r.kernel.org,
linux-riscv@...ts.infradead.org, tangmeng@...ontech.com
Subject: Re: [PATCH 0/3] riscv: sbi: Switch to the sys-off handler API
On Wed, 28 Dec 2022 08:19:12 PST (-0800), samuel@...lland.org wrote:
> I want to convert the axp20x PMIC poweroff handler to use the sys-off
> API, so it can be used as a fallback for if the SBI poweroff handler
> is unavailable. But the SBI poweroff handler still uses pm_power_off, so
> done alone, this would cause the axp20x callback to be called first,
> before the SBI poweroff handler has a chance to run.
>
> In order to prevent this change in behavior, the SBI poweroff handler
> needs to be converted to the sys-off API first, at a higher priority.
>
> This series performs the conversion, after accounting for the fact that
> the SBI poweroff handler is registered quite early during boot.
>
> The first patch is a dependency for both this series and the PSCI
> series[1], so I would like to get at least patch 1 merged soon.
>
> [1]: https://lore.kernel.org/lkml/20221105214841.7828-1-samuel@sholland.org/
>
>
> Samuel Holland (3):
> kernel/reboot: Use the static sys-off handler for any priority
> riscv: sbi: Share the code for unsupported extension warnings
> riscv: sbi: Switch to the sys-off handler API
>
> arch/riscv/include/asm/sbi.h | 1 -
> arch/riscv/kernel/sbi.c | 63 +++++++++++++++++++++---------------
> kernel/reboot.c | 10 +++---
> 3 files changed, 41 insertions(+), 33 deletions(-)
Samuel: do you mind rebasing this and resending it with the reboot folks
in the To list? That way we might be able to get an Ack on the generic
bits.
Thanks!
Powered by blists - more mailing lists