linux-kernel - Re: [PATCH 1/2] Revert "scsi: core: Do not increase scsi_device's iorequest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZGHxLixW2rR34S+e@ovpn-8-26.pek2.redhat.com>
Date:   Mon, 15 May 2023 16:45:34 +0800
From:   Ming Lei <ming.lei@...hat.com>
To:     Wenchao Hao <haowenchao2@...wei.com>
Cc:     "James E . J . Bottomley" <jejb@...ux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        linfeilong@...wei.com, louhongxiang@...wei.com
Subject: Re: [PATCH 1/2] Revert "scsi: core: Do not increase scsi_device's
 iorequest_cnt if dispatch failed"

On Mon, May 15, 2023 at 03:01:55PM +0800, Wenchao Hao wrote:
> the "atomic_inc(&cmd->device->iorequest_cnt)" in scsi_queue_rq() would
> causes kernel panic, because cmd->device may be freed after returning
> from scsi_dispatch_cmd().
> 
> This reverts commit cfee29ffb45b1c9798011b19d454637d1b0fe87d.
> 
> Signed-off-by: Wenchao Hao <haowenchao2@...wei.com>
> Reported-by: Ming Lei <ming.lei@...hat.com>
> Closes:https://lore.kernel.org/linux-scsi/8e0f2d31-e6ff-ec4a-3974-450560ad49c5@huawei.com/T/#t

Reviewed-by: Ming Lei <ming.lei@...hat.com>

Thanks,
Ming