linux-kernel - Re: [PATCH v8 10/11] arm64: dts: qcom: sm8350: Add Crypto Engine support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 16 Jun 2023 19:36:07 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Bhupesh Sharma <bhupesh.sharma@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org
Cc:     agross@...nel.org, linux-kernel@...r.kernel.org,
        linux-crypto@...r.kernel.org, andersson@...nel.org,
        bhupesh.linux@...il.com, robh+dt@...nel.org,
        konrad.dybcio@...aro.org, vladimir.zapolskiy@...aro.org,
        rfoss@...nel.org, neil.armstrong@...aro.org, djakov@...nel.org,
        stephan@...hold.net, Anders Roxell <anders.roxell@...aro.org>,
        Linux Kernel Functional Testing <lkft@...aro.org>
Subject: Re: [PATCH v8 10/11] arm64: dts: qcom: sm8350: Add Crypto Engine
 support

On 26/05/2023 21:22, Bhupesh Sharma wrote:
> Add crypto engine (CE) and CE BAM related nodes and definitions to
> 'sm8350.dtsi'.
> 
> Tested-by: Anders Roxell <anders.roxell@...aro.org>
> Tested-by: Linux Kernel Functional Testing <lkft@...aro.org>
> Co-developed-by and Signed-off-by: Robert Foss <rfoss@...nel.org>
> [Bhupesh: Switch to '#interconnect-cells = <2>', available since commit 4f287e31ff5f]
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@...aro.org>
> ---

#regzbot introduced: f1040a7fe8f069d2259ab3dab9190210005ceb33
#regzbot title: HDK8350 silently crashes early on boot

Hi, this landed in the next but unfortunately it causes silent crash
(and reboot) of HDK8350. Reverting this commit helps.

Log is more or less like:

[    1.359340] Bluetooth: HCI UART driver ver 2.3
[    1.363929] Bluetooth: HCI UART protocol H4 registered
[    1.369243] Bluetooth: HCI UART protocol LL registered
[    1.374639] Bluetooth: HCI UART protocol Broadcom registered
[    1.380476] Bluetooth: HCI UART protocol QCA registered
[    1.385868] Bluetooth: HCI UART protocol Marvell registered
[    1.391623] usbcore: registered new interface driver btusb
[    1.397273] ghes_edac: GHES probing device list is empty
[    1.400305] sdhci: Secure Digital Host Controller Interface driver
[    1.412124] sdhci: Copyright(c) Pierre Ossman
[    1.417494] Synopsys Designware Multimedia Card Interface Driver
[    1.424823] sdhci-pltfm: SDHCI platform and OF driver helper
[    1.433783] ledtrig-cpu: registered to indicate activity on CPUs
[    1.442236] usbcore: registered new interface driver usbhid
[    1.447982] usbhid: USB HID core driver
[    1.457065] hw perfevents: enabled with armv8_pmuv3 PMU driver, 7
counters available
[    1.473760] NET: Registered PF_PACKET protocol family
[    1.479044] 9pnet: Installing 9P2000 support
[    1.483491] Key type dns_resolver registered
[    1.496583] registered taskstats version 1
[    1.500951] Loading compiled-in X.509 certificates
[    1.519456] platform 18200000.rsc:regulators-0: Fixed dependency
cycle(s) with /soc@...sc@...00000/regulators-0/smps11
[    1.530916] platform 18200000.rsc:regulators-1: Fixed dependency
cycle(s) with /soc@...sc@...00000/regulators-0/smps12
[    1.541906] platform 18200000.rsc:regulators-1: Fixed dependency
cycle(s) with /soc@...sc@...00000/regulators-1/bob
[    1.552625] platform 18200000.rsc:regulators-1: Fixed dependency
cycle(s) with /soc@...sc@...00000/regulators-1/smps1
[    1.563730] vreg_s10b_1p8: Setting 1800000-1800000uV
[    1.564861] vreg_s1c_1p86: Setting 1856000-1880000uV
[    1.569411] vreg_s11b_0p95: Setting 952000-952000uV
[    1.574304] vreg_bob: Setting 3008000-3960000uV
[    1.576918] bam-dFormat: Log Type - Time(microsec) - Message -
Optional Info
Log Type: B - Since Boot(Power On Reset),  D - Delta,  S - Statistic
S - QC_IMAGE_VERSION_STRING=BOOT.MXF.1.0-00637.1-LAHAINA-1
S - IMAGE_VARIANT_STRING=SocLahainaLAA
S - OEM_IMAGE_VERSION_STRING=crm-ubuntu77
S - Boot Interface: UFS
S - Secure Boot: Off

defconfig with builtin INTERCONNECT_QCOM_SM8350 and several other options.

Can it be that some dependency is missing in linux-next or Bjorn's tree?
Shall we revert it?

Best regards,
Krzysztof