linux-kernel - Re: [cocci] [PATCH] Revert "debugfs, coccinelle: check for obsolete DEFINE_SIMPLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ZK1jYI/wyaxWnXrz@google.com>
Date:   Tue, 11 Jul 2023 07:12:48 -0700
From:   Sean Christopherson <seanjc@...gle.com>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     cocci@...ia.fr, kernel-janitors@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Julia Lawall <Julia.Lawall@...ia.fr>,
        Nicolas Palix <nicolas.palix@...g.fr>,
        Paolo Bonzini <pbonzini@...hat.com>
Subject: Re: [cocci] [PATCH] Revert "debugfs, coccinelle: check for obsolete
 DEFINE_SIMPLE_ATTRIBUTE() usage"

On Tue, Jul 11, 2023, Markus Elfring wrote:
> > Remove coccinelle's recommendation to use DEFINE_SIMPLE_ATTRIBUTE()
> > instead of DEFINE_SIMPLE_ATTRIBUTE().
> 
> I find this wording inappropriate for a change request
> because of an undesirable term duplication.
> Would you like to refer to the identifier “DEFINE_DEBUGFS_ATTRIBUTE” here?

Doh, copy+paste fail on my part.

> >                                        Regardless of whether or not the
> > "significant overhead" incurred by debugfs_create_file() is actually
> > meaningful, warnings from the script have led to a rash of low-quality
> > patches that have sowed confusion and consumed maintainer time for little
> > to no benefit.  There have been no less than four attempts to "fix" KVM,
> > and a quick search on lore shows that KVM is not alone.
> 
> Will such information trigger any further clarification?

I don't quite follow the question.  What information, and what clarification?