linux-kernel - Re: [PATCH V5] regulator: da9062: Make the use of IRQ optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8558f2aa-09fd-4cd3-ae1e-c80893e00aa1@sirena.org.uk>
Date:   Thu, 13 Jul 2023 17:34:24 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Christoph Niedermaier <cniedermaier@...electronics.com>
Cc:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Support Opensource <support.opensource@...semi.com>,
        Adam Thomson <Adam.Thomson.Opensource@...semi.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Marek Vasut <marex@...x.de>,
        kernel <kernel@...electronics.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V5] regulator: da9062: Make the use of IRQ optional

On Thu, Jul 13, 2023 at 03:36:38PM +0000, Christoph Niedermaier wrote:
> From: Mark Brown [mailto:broonie@...nel.org]

> > Are there any dependencies for this patch?  The fact that I acked it
> > makes me think there were MFD parts

> It's a patch series. This patch is the last one in this series, that is
> missing to have the ability to run the DA9061/62 without a connected IRQ
> pin. The other patches are already upstreamed and yes there are MFD parts,
> see below:

Oh, dear.  Why weren't they applied, it's not even the confusion there
was over what Reviewed-by means...

> >> Reported-by: kernel test robot <lkp@...el.com>
> >> Link: https://lore.kernel.org/oe-kbuild-all/202303082246.GuLdPL0t-lkp@intel.com/

> > I really doubt that the LKP bot ran into an issue due to a system with
> > this device without an IRQ wired up...

> In V3 of this patch the kernel test robot found an issue. I had really
> overlooked that. Thanks to LKP. I forgot to replace the irq variable in
> the function devm_request_threaded_irq(). So it affected the path with
> IRQ. In V4 I fixed that. In V5 I only rebased it on the current next
> 20230713 and add Marek's Reviewed-by tag.

That doesn't mean you should include tags like this, it makes it look
like they reported the commit...

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)