linux-kernel - Re: [PATCH v3 1/2] regulator: dt-bindings: rtq2208: Add Richtek RTQ2208 SubPMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 Jul 2023 16:46:19 +0800
From:   Alina Yu <alina_yu@...htek.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
CC:     <lgirdwood@...il.com>, <broonie@...nel.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <alina_yu@...htek.com>
Subject: Re: [PATCH v3 1/2] regulator: dt-bindings: rtq2208: Add Richtek
 RTQ2208 SubPMIC

Hi,
Krzysztof,

On Wed, Jul 19, 2023 at 09:43:03AM +0200, Krzysztof Kozlowski wrote:
> On 19/07/2023 06:25, alina_yu@...htek.com wrote:
> > From: alinayu <alina_yu@...htek.com>
> > 
> > Add bindings for Richtek RTQ2208 IC controlled SubPMIC
> > 
> > Signed-off-by: Alina Yu <alina_yu@...htek.com>
> > ---
> > v3
> > - Fix some typos
> > - Modify the descriptions for "richtek,mtp-sel"
> > - Modify the node name to lowercase and remove underscore
> > - Remove '|' from description
> > - Remove "regulator-compatible" from property
> > - Remove "regulator-state-mem" from pattern
> > - Modify node name to generic one
> > ---
> >  .../regulator/richtek,rtq2208-regulator.yaml       | 206 +++++++++++++++++++++
> >  1 file changed, 206 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml b/Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml
> > new file mode 100644
> > index 0000000..2fc92e5
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml
> 
> No improvements here.
> 
> This is a friendly reminder during the review process.
> 
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all
> requested changes or keep discussing them.
> 
> Thank you.
> 
> Best regards,
> Krzysztof
> 


Sorry, I missed this one "Filename like compatible".
If I modify the filename to "richtek,rtq2208.yaml", is it unlike a compatible ?

Best regards,
Alina