linux-kernel - Re: [PATCH v3 33/50] dt-bindings: usb: add sam9x7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230728192259.GA1164895-robh@kernel.org>
Date:   Fri, 28 Jul 2023 13:22:59 -0600
From:   Rob Herring <robh@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Varshini Rajendran <varshini.rajendran@...rochip.com>,
        gregkh@...uxfoundation.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, linux-usb@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 33/50] dt-bindings: usb: add sam9x7

On Fri, Jul 28, 2023 at 01:48:01PM +0200, Krzysztof Kozlowski wrote:
> On 28/07/2023 12:28, Varshini Rajendran wrote:
> > Document sam9x7 compatible for usb ohci.
> > 
> > Signed-off-by: Varshini Rajendran <varshini.rajendran@...rochip.com>
> > ---
> >  Documentation/devicetree/bindings/usb/generic-ohci.yaml | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> > index be268e23ca79..a2490759f694 100644
> > --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> > +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> > @@ -57,6 +57,12 @@ properties:
> >                - nxp,ohci-nxp
> >                - st,spear600-ohci
> >            - const: usb-ohci
> > +      - items:
> > +          - enum:
> > +              - microchip,sam9x7-ohci
> > +          - enum:
> 
> That's not an enum. You cannot have here different compatibles.
> 
> > +              - atmel,at91rm9200-ohci
> > +          - const: usb-ohci

As mentioned elsewhere, you aren't really compatible having custom 
properties. If you are adding this here, then stuff should be removed 
from the .txt binding. You need to sort out this mess and the existing 
warnings with 'usb-ohci' in Atmel dts files before adding on to it.

Rob