linux-kernel - Re: [PATCH v3 33/50] dt-bindings: usb: add sam9x7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c03f4364-3d97-531a-8acc-aae68de39562@linaro.org>
Date:   Fri, 28 Jul 2023 13:48:01 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Varshini Rajendran <varshini.rajendran@...rochip.com>,
        gregkh@...uxfoundation.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 33/50] dt-bindings: usb: add sam9x7

On 28/07/2023 12:28, Varshini Rajendran wrote:
> Document sam9x7 compatible for usb ohci.
> 
> Signed-off-by: Varshini Rajendran <varshini.rajendran@...rochip.com>
> ---
>  Documentation/devicetree/bindings/usb/generic-ohci.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> index be268e23ca79..a2490759f694 100644
> --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> @@ -57,6 +57,12 @@ properties:
>                - nxp,ohci-nxp
>                - st,spear600-ohci
>            - const: usb-ohci
> +      - items:
> +          - enum:
> +              - microchip,sam9x7-ohci
> +          - enum:

That's not an enum. You cannot have here different compatibles.

> +              - atmel,at91rm9200-ohci
> +          - const: usb-ohci
>  
>    reg:
>      maxItems: 1

Best regards,
Krzysztof