[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <169097098854.265879.2537978394359079455.kvalo@kernel.org>
Date: Wed, 2 Aug 2023 10:09:50 +0000 (UTC)
From: Kalle Valo <kvalo@...nel.org>
To: Azeem Shaikh <azeemshaikh38@...il.com>
Cc: Felix Fietkau <nbd@....name>,
Lorenzo Bianconi <lorenzo@...nel.org>,
Ryder Lee <ryder.lee@...iatek.com>,
linux-hardening@...r.kernel.org,
Azeem Shaikh <azeemshaikh38@...il.com>,
Shayne Chen <shayne.chen@...iatek.com>,
Sean Wang <sean.wang@...iatek.com>,
linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org
Subject: Re: wifi: mt76: Replace strlcpy() with strscpy()
Azeem Shaikh <azeemshaikh38@...il.com> wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
>
> Direct replacement is safe here since DEV_ASSIGN is only used by
> TRACE macros and the return values are ignored.
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> [2] https://github.com/KSPP/linux/issues/89
>
> Signed-off-by: Azeem Shaikh <azeemshaikh38@...il.com>
> Reviewed-by: Kees Cook <keescook@...omium.org>
Patch applied to wireless-next.git, thanks.
d6b484b5cb2a wifi: mt76: Replace strlcpy() with strscpy()
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230703181256.3712079-1-azeemshaikh38@gmail.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists