linux-kernel - Re: [PATCH] romfs: only select BUFFER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 4 Aug 2023 12:38:05 +0200
From:   Christoph Hellwig <hch@....de>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     axboe@...nel.dk, lizetao1@...wei.com, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, Christoph Hellwig <hch@....de>
Subject: Re: [PATCH] romfs: only select BUFFER_HEAD for the block based path

Sorry, this should be:

From: Christoph Hellwig <hch@....de>

to match the signoff.  I managed to mess my mail setup, but it should
be fixed now.


On Fri, Aug 04, 2023 at 12:26:48PM +0200, Christoph Hellwig wrote:
> selecting BUFFER_HEAD unconditionally does not work as romfs can also
> be built with only the MTD backend and thus without CONFIG_BLOCK.
> 
> Fixes: 0f842210d97a ("fs/Kconfig: Fix compile error for romfs")
> Signed-off-by: Christoph Hellwig <hch@....de>
> ---
>  fs/romfs/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/romfs/Kconfig b/fs/romfs/Kconfig
> index 3f6b550eee6192..f24a96a331af1b 100644
> --- a/fs/romfs/Kconfig
> +++ b/fs/romfs/Kconfig
> @@ -2,7 +2,6 @@
>  config ROMFS_FS
>  	tristate "ROM file system support"
>  	depends on BLOCK || MTD
> -	select BUFFER_HEAD
>  	help
>  	  This is a very small read-only file system mainly intended for
>  	  initial ram disks of installation disks, but it could be used for
> @@ -58,6 +57,7 @@ endchoice
>  config ROMFS_ON_BLOCK
>  	bool
>  	default y if ROMFS_BACKED_BY_BLOCK || ROMFS_BACKED_BY_BOTH
> +	select BUFFER_HEAD
>  
>  config ROMFS_ON_MTD
>  	bool
> -- 
> 2.39.2
---end quoted text---