linux-kernel - Re: [PATCH] perf/smmuv3: Add platform id table for module auto loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGsJ_4z5kYWOa2L+BHypM4S6W_UhUfUe3wo2rwiy0u7Hf1Q5pw@mail.gmail.com>
Date:   Wed, 9 Aug 2023 13:47:31 +0800
From:   Barry Song <21cnbao@...il.com>
To:     Liang Li <liliang6@...il.cn>
Cc:     Yicong Yang <yangyicong@...wei.com>, will@...nel.org,
        mark.rutland@....com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, jonathan.cameron@...wei.com,
        linuxarm@...wei.com, yangyicong@...ilicon.com
Subject: Re: [PATCH] perf/smmuv3: Add platform id table for module auto loading

On Wed, Aug 9, 2023 at 1:01 PM Liang Li <liliang6@...il.cn> wrote:
>
> On 2023-08-07 20:22, Yicong Yang <yangyicong@...wei.com> wrote:
> > From: Yicong Yang <yangyicong@...ilicon.com>
> >
> > On ACPI based system the device is probed by the name directly. If the
> > driver is configured as module it can only be loaded manually. Add the
> > platform id table as well as the module alias then the driver will be
> > loaded automatically by the udev or others once the device added.
> >
>
> Please consider revise the long log to clearly express the purpose of the
> changes in this patch:
>
> - What's the exact issue the patch is addressing
> - Why the changes in this patch can fix the issue or make something working
> - Consider impact of the changes introduced by this patch
>
> These info may help reviewers and maintainers .. and yourself on code merge.

years ago, i found a good doc regarding this,
https://wiki.archlinux.org/title/Modalias

guess it is because /lib/modules/$(uname -r)/modules.alias fails to contain smmu
driver without the MODULE_DEVICE_TABLE, isn't it, yicong？

>
> Regards.
>

Thanks
Barry