linux-kernel - Re: [PATCH 1/4] dt-bindings: clock: qcom: Add ECPRICC clocks for QDU1000 and QRU1000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bb1b6310-0142-800a-8edb-fb9163d8da75@quicinc.com>
Date:   Tue, 22 Aug 2023 17:16:18 +0530
From:   Imran Shaik <quic_imrashai@...cinc.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        "Michael Turquette" <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        "Rob Herring" <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>
CC:     Taniya Das <quic_tdas@...cinc.com>,
        <linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Ajit Pandey <quic_ajipan@...cinc.com>,
        Jagadeesh Kona <quic_jkona@...cinc.com>
Subject: Re: [PATCH 1/4] dt-bindings: clock: qcom: Add ECPRICC clocks for
 QDU1000 and QRU1000



On 8/16/2023 11:19 AM, Krzysztof Kozlowski wrote:
> On 08/08/2023 07:14, Imran Shaik wrote:
>> Add device tree bindings for qcom ecpri clock controller on QDU1000 and
>> QRU1000 SoCs.
>>
>> Signed-off-by: Imran Shaik <quic_imrashai@...cinc.com>
>> ---
>>   .../bindings/clock/qcom,qdu1000-ecpricc.yaml  |  68 +++++++
>>   .../dt-bindings/clock/qcom,qdu1000-ecpricc.h  | 192 ++++++++++++++++++
>>   2 files changed, 260 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/clock/qcom,qdu1000-ecpricc.yaml
>>   create mode 100644 include/dt-bindings/clock/qcom,qdu1000-ecpricc.h
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,qdu1000-ecpricc.yaml b/Documentation/devicetree/bindings/clock/qcom,qdu1000-ecpricc.yaml
>> new file mode 100644
>> index 000000000000..db54052bf360
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/qcom,qdu1000-ecpricc.yaml
>> @@ -0,0 +1,68 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/clock/qcom,qdu1000-ecpricc.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm ECPRI Clock & Reset Controller for QDU1000 and QRU1000
>> +
>> +maintainers:
>> +  - Taniya Das <quic_tdas@...cinc.com>
>> +  - Imran Shaik <quic_imrashai@...cinc.com>
>> +
>> +description: |
>> +  Qualcomm ecpri clock control module which supports the clocks, resets
>> +  on QDU1000 and QRU1000
>> +
>> +  See also:: include/dt-bindings/clock/qcom,qdu1000-ecpricc.h
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - qcom,qdu1000-ecpricc
>> +
>> +  clocks:
>> +    items:
>> +      - description: Board XO source
>> +      - description: GPLL0 source from GCC
>> +      - description: GPLL1 source from GCC
>> +      - description: GPLL2 source from GCC
>> +      - description: GPLL3 source from GCC
>> +      - description: GPLL4 source from GCC
>> +      - description: GPLL5 source from GCC
>> +
>> +  '#clock-cells':
>> +    const: 1
>> +
>> +  '#reset-cells':
>> +    const: 1
>> +
>> +  reg:
>> +    maxItems: 1
> 
> Keep the same order as in required: below.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> Best regards,
> Krzysztof
> 

Sure, will update this in next series.

Thanks,
Imran