linux-kernel - Re: [PATCH net] ipv6: mcast: Remove redundant comparison in igmp6_mcf_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cdc2183a-c79a-b4bd-2726-bd3a2d6d5440@kernel.org>
Date:   Mon, 28 Aug 2023 20:44:25 -0600
From:   David Ahern <dsahern@...nel.org>
To:     Gavrilov Ilia <Ilia.Gavrilov@...otecs.ru>,
        "David S. Miller" <davem@...emloft.net>
Cc:     Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "lvc-project@...uxtesting.org" <lvc-project@...uxtesting.org>
Subject: Re: [PATCH net] ipv6: mcast: Remove redundant comparison in
 igmp6_mcf_get_next()

On 8/28/23 5:18 AM, Gavrilov Ilia wrote:
> The 'state->im' value will always be non-zero after
> the 'while' statement, so the check can be removed.
> 
> Found by InfoTeCS on behalf of Linux Verification Center
> (linuxtesting.org) with SVACE.
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Gavrilov Ilia <Ilia.Gavrilov@...otecs.ru>
> ---
>  net/ipv6/mcast.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c
> index 714cdc9e2b8e..9696343d0aa9 100644
> --- a/net/ipv6/mcast.c
> +++ b/net/ipv6/mcast.c
> @@ -3013,8 +3013,6 @@ static struct ip6_sf_list *igmp6_mcf_get_next(struct seq_file *seq, struct ip6_s
>  				continue;
>  			state->im = rcu_dereference(state->idev->mc_list);
>  		}
> -		if (!state->im)
> -			break;
>  		psf = rcu_dereference(state->im->mca_sources);
>  	}
>  out:

agree the check is not needed, but I also believe it does not need to be
backported. Since net-next is closed, resubmit after 9/11.

--
pw-bot: defer