linux-kernel - Re: [PATCH net] ipv6: mcast: Remove redundant comparison in igmp6_mcf_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1b0dc662-7d77-81a6-73cc-4f3f9c6cc915@infotecs.ru>
Date:   Tue, 29 Aug 2023 06:55:42 +0000
From:   Gavrilov Ilia <Ilia.Gavrilov@...otecs.ru>
To:     David Ahern <dsahern@...nel.org>,
        "David S. Miller" <davem@...emloft.net>
CC:     Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "lvc-project@...uxtesting.org" <lvc-project@...uxtesting.org>
Subject: Re: [PATCH net] ipv6: mcast: Remove redundant comparison in
 igmp6_mcf_get_next()

On 8/29/23 05:44, David Ahern wrote:
> On 8/28/23 5:18 AM, Gavrilov Ilia wrote:
>> The 'state->im' value will always be non-zero after
>> the 'while' statement, so the check can be removed.
>>
>> Found by InfoTeCS on behalf of Linux Verification Center
>> (linuxtesting.org) with SVACE.
>>
>> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
>> Signed-off-by: Gavrilov Ilia <Ilia.Gavrilov@...otecs.ru>
>> ---
>>   net/ipv6/mcast.c | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c
>> index 714cdc9e2b8e..9696343d0aa9 100644
>> --- a/net/ipv6/mcast.c
>> +++ b/net/ipv6/mcast.c
>> @@ -3013,8 +3013,6 @@ static struct ip6_sf_list *igmp6_mcf_get_next(struct seq_file *seq, struct ip6_s
>>   				continue;
>>   			state->im = rcu_dereference(state->idev->mc_list);
>>   		}
>> -		if (!state->im)
>> -			break;
>>   		psf = rcu_dereference(state->im->mca_sources);
>>   	}
>>   out:
> 
> agree the check is not needed, but I also believe it does not need to be
> backported. Since net-next is closed, resubmit after 9/11.
> 
> --
> pw-bot: defer

I'll resend it after 9/11.
Thank you for the review!