linux-kernel - Re: [PATCH net] ipv4: igmp: Remove redundant comparison in igmp_mcf_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fea6db56-3a01-b7c8-b800-a6c885e99feb@kernel.org>
Date:   Mon, 28 Aug 2023 20:45:22 -0600
From:   David Ahern <dsahern@...nel.org>
To:     Gavrilov Ilia <Ilia.Gavrilov@...otecs.ru>,
        "David S. Miller" <davem@...emloft.net>
Cc:     Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "lvc-project@...uxtesting.org" <lvc-project@...uxtesting.org>
Subject: Re: [PATCH net] ipv4: igmp: Remove redundant comparison in
 igmp_mcf_get_next()

On 8/28/23 3:01 AM, Gavrilov Ilia wrote:
> The 'state->im' value will always be non-zero after
> the 'while' statement, so the check can be removed.
> 
> Found by InfoTeCS on behalf of Linux Verification Center
> (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Gavrilov Ilia <Ilia.Gavrilov@...otecs.ru>
> ---
>  net/ipv4/igmp.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c
> index 48ff5f13e797..6ebf06886527 100644
> --- a/net/ipv4/igmp.c
> +++ b/net/ipv4/igmp.c
> @@ -2943,8 +2943,6 @@ static struct ip_sf_list *igmp_mcf_get_next(struct seq_file *seq, struct ip_sf_l
>  				continue;
>  			state->im = rcu_dereference(state->idev->mc_list);
>  		}
> -		if (!state->im)
> -			break;
>  		spin_lock_bh(&state->im->lock);
>  		psf = state->im->sources;
>  	}

Same with this one: agree the check is not needed, but I also believe it
does not need to be backported. Since net-next is closed, resubmit after
9/11.

--
pw-bot: defer