linux-kernel - Re: [PATCH 1/1] x86/entry: remove unused argument %rsi passed to exc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0EE710EE-C0A3-4D29-BEF3-5FF888A5AD01@zytor.com>
Date:   Wed, 27 Sep 2023 12:15:34 -0700
From:   "H. Peter Anvin" <hpa@...or.com>
To:     Ingo Molnar <mingo@...nel.org>, xin@...or.com
CC:     linux-kernel@...r.kernel.org, luto@...nel.org, tglx@...utronix.de,
        mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com,
        x86@...nel.org
Subject: Re: [PATCH 1/1] x86/entry: remove unused argument %rsi passed to exc_nmi()

On September 27, 2023 1:06:23 AM PDT, Ingo Molnar <mingo@...nel.org> wrote:
>
>* xin@...or.com <xin@...or.com> wrote:
>
>> From: "Xin Li (Intel)" <xin@...or.com>
>> 
>> exc_nmi() only takes one argument of type struct pt_regs *, but
>> asm_exc_nmi() calls it with 2 arguments. The second one passed
>> in %rsi seems a leftover, so simply remove it.
>> 
>> BTW, fix 2 slips in the comments.
>> 
>> Signed-off-by: Xin Li (Intel) <xin@...or.com>
>> Acked-by: H. Peter Anvin (Intel) <hpa@...or.com>
>> ---
>>  arch/x86/entry/entry_64.S | 10 ++++------
>>  1 file changed, 4 insertions(+), 6 deletions(-)
>
>I've split this into two patches, because the comment fixes
>are entirely unrelated to this patch.
>
>[ I've propagated the SOBs and Acked-by's to the two patches,
>  as I presume is fine by everyone involved? ]
>
>Thanks,
>
>	Ingo

Perfect, thanks!