linux-kernel - Re: [PATCH v3] firmware_loader: Abort new fw load request once firmware core knows about reboot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZTacD4tWZHrzhmQT@bombadil.infradead.org>
Date:   Mon, 23 Oct 2023 09:15:11 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Mukesh Ojha <quic_mojha@...cinc.com>
Cc:     russell.h.weight@...el.com, gregkh@...uxfoundation.org,
        rafael@...nel.org, linux-kernel@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH v3] firmware_loader: Abort new fw load request once
 firmware core knows about reboot

On Mon, Oct 23, 2023 at 06:11:18PM +0530, Mukesh Ojha wrote:
> However, if you think we should rename this
> 'only_kill_custom' to something like its inverse 'kill_all' and reverse the
> below check to be more meaningful now ?
> 
>    		if (kill_all || !fw_priv->need_uevent)

This seems like a better approach to make the intent clear and avoid
future confusion.

  Luis