linux-kernel - Re: [PATCH 02/10] ipmi: kcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d1ab4c5b175099fc204909e5430c87fb55565e56.camel@codeconstruct.com.au>
Date:   Mon, 06 Nov 2023 09:17:26 +1030
From:   Andrew Jeffery <andrew@...econstruct.com.au>
To:     Jonathan Cameron <Jonathan.Cameron@...wei.com>
Cc:     minyard@....org, openipmi-developer@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, aladyshev22@...il.com,
        jk@...econstruct.com.au
Subject: Re: [PATCH 02/10] ipmi: kcs_bmc: Include spinlock.h

On Fri, 2023-11-03 at 14:36 +0000, Jonathan Cameron wrote:
> On Fri,  3 Nov 2023 16:45:14 +1030
> Andrew Jeffery <andrew@...econstruct.com.au> wrote:
> 
> > struct kcs_bmc_device defines a spinlock member but the header in which
> > it is defined failed to include the spinlock header. In the spirit of
> > include-what-you-use, do what's necessary.
> > 
> > Signed-off-by: Andrew Jeffery <andrew@...econstruct.com.au>
> This is fine, but whilst checking it I noticed there is no
> forwards def of struct device or appropriate include.

Ah, I'll fix that too.

clangd automatically added the spinlock include at one point and so I
figured I'd capture it.

Andrew