[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZU47hV1i66WN8nZJ@makrotopia.org>
Date: Fri, 10 Nov 2023 14:17:41 +0000
From: Daniel Golle <daniel@...rotopia.org>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>
Cc: Wim Van Sebroeck <wim@...ux-watchdog.org>,
Guenter Roeck <linux@...ck-us.net>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Matthias Brugger <matthias.bgg@...il.com>,
Philipp Zabel <p.zabel@...gutronix.de>,
linux-watchdog@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: watchdog: mediatek,mtk-wdt: add MT7988
watchdog and toprgu
On Fri, Nov 10, 2023 at 12:56:18PM +0100, AngeloGioacchino Del Regno wrote:
> Il 10/11/23 01:30, Daniel Golle ha scritto:
> > Add binding description for mediatek,mt7988-wdt.
> >
> > Signed-off-by: Daniel Golle <daniel@...rotopia.org>
> > ---
> > .../bindings/watchdog/mediatek,mtk-wdt.yaml | 1 +
> > include/dt-bindings/reset/mediatek,mt7988-resets.h | 12 ++++++++++++
> > 2 files changed, 13 insertions(+)
> > create mode 100644 include/dt-bindings/reset/mediatek,mt7988-resets.h
> >
> > diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
> > index cc502838bc398..8d2520241e37f 100644
> > --- a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
> > @@ -25,6 +25,7 @@ properties:
> > - mediatek,mt6735-wdt
> > - mediatek,mt6795-wdt
> > - mediatek,mt7986-wdt
> > + - mediatek,mt7988-wdt
> > - mediatek,mt8183-wdt
> > - mediatek,mt8186-wdt
> > - mediatek,mt8188-wdt
> > diff --git a/include/dt-bindings/reset/mediatek,mt7988-resets.h b/include/dt-bindings/reset/mediatek,mt7988-resets.h
> > new file mode 100644
> > index 0000000000000..fa7c937505e08
> > --- /dev/null
> > +++ b/include/dt-bindings/reset/mediatek,mt7988-resets.h
> > @@ -0,0 +1,12 @@
> > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> > +
> > +/* TOPRGU resets */
>
> The first reset is zero, the second reset is one.
>
> Where's the zero'th reset? :-)
Currently the reset numbers represent the corresponding bit positions in
the toprgu register, as this is how the mtk-wdt driver is organized.
So there is probably something at bit 0, and also at bit 3~11 and
maybe also 17~23, but it's unknown and may be added later once known
and/or needed.
>
> Regards,
> Angelo
>
> > +#define MT7988_TOPRGU_SGMII0_GRST 1
> > +#define MT7988_TOPRGU_SGMII1_GRST 2
> > +#define MT7988_TOPRGU_XFI0_GRST 12
> > +#define MT7988_TOPRGU_XFI1_GRST 13
> > +#define MT7988_TOPRGU_XFI_PEXTP0_GRST 14
> > +#define MT7988_TOPRGU_XFI_PEXTP1_GRST 15
> > +#define MT7988_TOPRGU_XFI_PLL_GRST 16
> > +
> > +#define MT7988_TOPRGU_SW_RST_NUM 24
>
>
Powered by blists - more mailing lists