linux-kernel - Re: [PATCH v3 01/25] i2c: designware: Delete adapter before disabling in i2c_dw_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Nov 2023 15:49:05 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Jarkko Nikula <jarkko.nikula@...ux.intel.com>
Cc:     Mario Limonciello <mario.limonciello@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Wolfram Sang <wsa@...nel.org>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Jan Dabros <jsd@...ihalf.com>,
        Andi Shyti <andi.shyti@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Hans de Goede <hdegoede@...hat.com>
Subject: Re: [PATCH v3 01/25] i2c: designware: Delete adapter before
 disabling in i2c_dw_pci_remove()

On Wed, Nov 15, 2023 at 11:45:10AM +0200, Jarkko Nikula wrote:
> On 11/10/23 20:11, Andy Shevchenko wrote:
> > Make i2c_dw_pci_remove() to be aligned with dw_i2c_plat_remove() on
> > the sequence of the ceasing I²C operations.
> > 
> > Fixes: 18dbdda89f5c ("i2c-designware: Add runtime power management support")
> 
> I think this is wrong. Commit 18dbdda89f5c is 12 years ago so is this patch
> really fixing a real bug that was hiding all these years?

Why not? But let me check more careful the ordering between two and probe.

-- 
With Best Regards,
Andy Shevchenko