linux-kernel - Re: [PATCH] firmware: qcom: qcm: fix unused qcom_scm_qseecom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e7565064-42a4-43fd-82f7-2e84066bee55@linaro.org>
Date:   Tue, 21 Nov 2023 08:07:01 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Maximilian Luz <luzmaximilian@...il.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Johan Hovold <johan+linaro@...nel.org>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] firmware: qcom: qcm: fix unused
 qcom_scm_qseecom_allowlist

On 20/11/2023 20:56, Maximilian Luz wrote:
> On 11/20/23 19:56, Krzysztof Kozlowski wrote:
>> For !OF builds, the qcom_scm_qseecom_allowlist is unused:
>>
>>    drivers/firmware/qcom/qcom_scm.c:1652:34: error: ‘qcom_scm_qseecom_allowlist’ defined but not used [-Werror=unused-const-variable=]
>>
>> Fixes: 00b1248606ba ("firmware: qcom_scm: Add support for Qualcomm Secure Execution Environment SCM interface")
>> Reported-by: kernel test robot <lkp@...el.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202311191654.S4wlVUrz-lkp@intel.com/
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> ---
>>   drivers/firmware/qcom/qcom_scm.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c
>> index 520de9b5633a..ecdb367dc9b8 100644
>> --- a/drivers/firmware/qcom/qcom_scm.c
>> +++ b/drivers/firmware/qcom/qcom_scm.c
>> @@ -1649,7 +1649,7 @@ EXPORT_SYMBOL_GPL(qcom_scm_qseecom_app_send);
>>    * We do not yet support re-entrant calls via the qseecom interface. To prevent
>>    + any potential issues with this, only allow validated machines for now.
>>    */
>> -static const struct of_device_id qcom_scm_qseecom_allowlist[] = {
>> +static const struct of_device_id qcom_scm_qseecom_allowlist[] __maybe_unused = {
>>   	{ .compatible = "lenovo,thinkpad-x13s", },
>>   	{ }
>>   };
> 
> Thanks! Given that we're right now only allowing qseecom clients to load
> on devices within that list, maybe it would be cleaner to make
> QCOM_QSEECOM depend on OF explicitly instead?

There is no code dependency here. The driver should already depend on
ARCH_QCOM which select OF. Are you saying it does not depend on
ARCH_QCOM? Why?

> 
> Anyway, I'm also fine with this solution.
> 
> Acked-by: Maximilian Luz <luzmaximilian@...il.com>
> 

Best regards,
Krzysztof