linux-kernel - Re: [PATCH] Took care of some grammatical mistakes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 Nov 2023 11:08:46 +0100 (CET)
From:   Miroslav Benes <mbenes@...e.cz>
To:     Randy Dunlap <rdunlap@...radead.org>
cc:     Matthew Wilcox <willy@...radead.org>,
        attreyee-muk <tintinm2017@...il.com>, jpoimboe@...nel.org,
        jikos@...nel.org, pmladek@...e.com, joe.lawrence@...hat.com,
        corbet@....net, live-patching@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Took care of some grammatical mistakes

On Tue, 28 Nov 2023, Randy Dunlap wrote:

> 
> 
> On 11/28/23 06:12, Matthew Wilcox wrote:
> > On Mon, Nov 27, 2023 at 11:41:31AM -0800, Randy Dunlap wrote:
> >> Hi,
> >>
> >> On 11/27/23 07:57, attreyee-muk wrote:
> >>> Respected Maintainers, 
> >>>
> >>> I have made some grammatical changes in the livepatch.rst file where I
> >>> felt that the sentence would have sounded more correct and would have become easy for
> >>> beginners to understand by reading. 
> >>> Requesting review of my proposed changes from the mainatiners. 
> >>>
> >>> Thank You
> >>> Attreyee Mukherjee
> >>>
> >>> Signed-off-by: attreyee-muk <tintinm2017@...il.com>
> >>> ---
> >>>  Documentation/livepatch/livepatch.rst | 8 ++++----
> >>>  1 file changed, 4 insertions(+), 4 deletions(-)
> >>>
> >>> diff --git a/Documentation/livepatch/livepatch.rst b/Documentation/livepatch/livepatch.rst
> >>> index 68e3651e8af9..a2d2317b7d6b 100644
> >>> --- a/Documentation/livepatch/livepatch.rst
> >>> +++ b/Documentation/livepatch/livepatch.rst
> >>> @@ -35,11 +35,11 @@ and livepatching:
> >>>  
> >>>  All three approaches need to modify the existing code at runtime. Therefore
> >>> -they need to be aware of each other and not step over each other's toes.
> >>> +they need to be aware of each other and not step over each others' toes.
> >>
> >> I've never seen that written like that, so I disagree here. FWIW.
> > 
> > "Step over" is new to me too.  I see "step on" much more often.
> 
> Agreed.

Yes. Attreyee, please fix this instead.
 
> > As far as placement of the apostrophe,
> > https://ludwig.guru/s/step+on+each+others+toes
> > suggests either omitting the apostrophe or placing it after the s,
> > as attreyee-muk has done is most common.
> 
> Apparently you can find anything on the internet.  :)
> 
> Here's the other side:
> 
> https://jakubmarian.com/each-others-vs-each-others-in-english/

I am not a native speaker, but "step on each other's toe" sounds the best 
to me. Or perhaps even "they need to be aware of each other and not step 
on their toes" since it is then kind of implied? English is difficult :).

Miroslav