linux-kernel - Re: [PATCH] scripts/gdb: Fix lx-device-list-bus and lx-device-list-class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae225003-d7a8-41c3-b4f9-a66397512c21@broadcom.com>
Date:   Thu, 30 Nov 2023 14:00:32 -0800
From:   Florian Fainelli <florian.fainelli@...adcom.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org, Kuan-Ying.Lee@...iatek.com,
        Jan Kiszka <jan.kiszka@...mens.com>,
        Kieran Bingham <kbingham@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] scripts/gdb: Fix lx-device-list-bus and
 lx-device-list-class

On 11/30/23 13:51, Andrew Morton wrote:
> On Wed, 29 Nov 2023 20:33:16 -0800 Florian Fainelli <florian.fainelli@...adcom.com> wrote:
> 
>> After the conversion to bus_to_subsys() and class_to_subsys(), the gdb
>> scripts listing the system buses and classes respectively was broken,
>> fix those by returning the subsys_priv pointer and have the various
>> caller de-reference either the 'bus' or 'class' structure members
>> accordingly.
>>
>> Fixes: 83b9148df2c9 ("driver core: bus: bus iterator cleanups")
>> Fixes: 7b884b7f24b4 ("driver core: class.c: convert to only use class_to_subsys")
> 
> I don't know how -stable maintainers handle more than one Fixes:.  One
> of the above was released in 6.3, the other in 6.4.  What are they to
> do?

Neither are stable kernels fortunately, so any kernel >= 6.4 where both 
issues are present should be able to cleanly cherry-pick the change.

I suppose this should have called for me to issue two patches, one 
fixing lx-device-list-bus and the other one fixing lx-device-list-class, 
though it seems like this is such a niche usage that it may not matter 
that much.

> 
> My opinion: developers should use Fixes: as a request to -stable
> maintainers to target a particular kernel version (and later).
> 
> If the developers indeed want to fix both kernel versions then wouldn't
> two patches be best?
> 

They probably would, or I could submit a targeted fix for 6.3 for instance.
-- 
Florian


Download attachment "smime.p7s" of type "application/pkcs7-signature" (4221 bytes)