linux-kernel - Re: [PATCH 11/13] btrfs: open code set_io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1cc59fa-9260-4a42-b346-17862d0f8385@wdc.com>
Date:   Wed, 13 Dec 2023 09:09:47 +0000
From:   Johannes Thumshirn <Johannes.Thumshirn@....com>
To:     "hch@...radead.org" <hch@...radead.org>
CC:     Chris Mason <clm@...com>, Josef Bacik <josef@...icpanda.com>,
        David Sterba <dsterba@...e.com>,
        "linux-btrfs@...r.kernel.org" <linux-btrfs@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 11/13] btrfs: open code set_io_stripe for RAID56

On 13.12.23 09:58, Christoph Hellwig wrote:
> On Tue, Dec 12, 2023 at 04:38:09AM -0800, Johannes Thumshirn wrote:
>> Open code set_io_stripe() for RAID56, as it a) uses a different method to
>> calculate the stripe_index and b) doesn't need to go through raid-stripe-tree
>> mapping code.
> 
> Looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@....de>
> 
> I think raid stripe tree handling also really should move out of
> set_io_stripe.  Below is the latest I have, although it probably won't
> apply to your tree:
> 

That would work as well and replace patch 1 then. Let me think about it.