linux-kernel - Re: [PATCH] Docs/zh_CN: Fix the meaning of DEBUG to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a9cbebd8-dd6e-d81c-471f-f40dcc7196ea@linux.dev>
Date: Wed, 20 Dec 2023 02:47:29 +0800
From: Zenghui Yu <zenghui.yu@...ux.dev>
To: Jonathan Corbet <corbet@....net>, "JiaLong.Yang"
 <jialong.yang@...ngroup.cn>, Alex Shi <alexs@...nel.org>,
 Yanteng Si <siyanteng@...ngson.cn>
Cc: 2738078698@...com, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Docs/zh_CN: Fix the meaning of DEBUG to pr_debug()

On 2023/12/19 22:43, Jonathan Corbet wrote:
> "JiaLong.Yang" <jialong.yang@...ngroup.cn> writes:
> 
>> Signed-off-by: JiaLong.Yang <jialong.yang@...ngroup.cn>
>> ---
>>  Documentation/translations/zh_CN/core-api/printk-basics.rst | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/translations/zh_CN/core-api/printk-basics.rst b/Documentation/translations/zh_CN/core-api/printk-basics.rst
>> index 59c6efb3fc41..cafa01bccff2 100644
>> --- a/Documentation/translations/zh_CN/core-api/printk-basics.rst
>> +++ b/Documentation/translations/zh_CN/core-api/printk-basics.rst
>> @@ -100,7 +100,7 @@ printk()的用法通常是这样的::
>>  
>>  为了调试，还有两个有条件编译的宏：
>>  pr_debug()和pr_devel()，除非定义了 ``DEBUG`` (或者在pr_debug()的情况下定义了
>> -``CONFIG_DYNAMIC_DEBUG`` )，否则它们会被编译。
>> +``CONFIG_DYNAMIC_DEBUG`` )，否则它们不会被编译。
>>  
> 
> This patch needs an actual changelog.  Being illiterate in Chinese, I
> can't make any connection between the subject line and what has actually
> been done here.

Agreed. The change itself looks correct though, feel free to add my

Reviewed-by: Zenghui Yu <zenghui.yu@...ux.dev>

in your next revision (with Jon's suggestion addressed).

Thanks,
Zenghui