linux-kernel - Re: [PATCH V3 1/4] gpio: eic-sprd: Keep the clock rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAB9BWhdE3G7P=g4C-kLhE96+GnMNOjnNNP8LszjHhY83e=ojFg@mail.gmail.com>
Date: Fri, 5 Jan 2024 10:28:02 +0800
From: wenhua lin <wenhua.lin1994@...il.com>
To: Chunyan Zhang <zhang.lyra@...il.com>
Cc: Andy Shevchenko <andy.shevchenko@...il.com>, Wenhua Lin <Wenhua.Lin@...soc.com>, 
	Linus Walleij <linus.walleij@...aro.org>, Andy Shevchenko <andy@...nel.org>, 
	Bartosz Golaszewski <brgl@...ev.pl>, Orson Zhai <orsonzhai@...il.com>, 
	Baolin Wang <baolin.wang@...ux.alibaba.com>, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Xiongpeng Wu <xiongpeng.wu@...soc.com>
Subject: Re: [PATCH V3 1/4] gpio: eic-sprd: Keep the clock rtc_1k on

On Fri, Jan 5, 2024 at 10:18 AM Chunyan Zhang <zhang.lyra@...il.com> wrote:
>
> On Fri, 5 Jan 2024 at 10:11, wenhua lin <wenhua.lin1994@...il.com> wrote:
> >
> > On Thu, Jan 4, 2024 at 9:00 PM Andy Shevchenko
> > <andy.shevchenko@...il.com> wrote:
> > >
> > > On Thu, Jan 4, 2024 at 4:43 AM Wenhua Lin <Wenhua.Lin@...soc.com> wrote:
> > > >
> > > > The eic debounce does not have a clock of rtc_1k in the sleep state,
> > > > but the eic debounce will be used to wake up the system, therefore the
> > > > clock of rtc_1k needs to be kept open.
> > >
> > > ...
> > >
> > > > +#define SPRD_EIC_DBNC_FORCE_CLK                0x8000
> > >
> > > BIT(15) ?
> > >
> >
> > Yes, writing 1 to bit15 of the register can ensure that the clock of
> > rtc_1k remains normally on.
>
> Andy's comment means that you should use BIT(15) instead of 0x8000.
>

OK, thank you very much for your explanation, I will make changes in patch v4.

> >
> > > --
> > > With Best Regards,
> > > Andy Shevchenko