linux-kernel - Re: [PATCH] arm64: dts: ti: k3-am62p-mcu/wakeup: Disable MCU and wakeup R5FSS nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 26 Jan 2024 08:56:23 +0100
From: Wadim Egorov <w.egorov@...tec.de>
To: Vaishnav Achath <vaishnav.a@...com>, <nm@...com>, <vigneshr@...com>,
	<kristo@...nel.org>, <robh+dt@...nel.org>,
	<krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>
CC: <bb@...com>, <linux-arm-kernel@...ts.infradead.org>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<u-kumar1@...com>
Subject: Re: [PATCH] arm64: dts: ti: k3-am62p-mcu/wakeup: Disable MCU and
 wakeup R5FSS nodes


Am 21.01.24 um 14:40 schrieb Vaishnav Achath:
> K3 Remoteproc R5 driver requires reserved memory carveouts and
> mailbox configuration to instantiate the cores successfully.
> Since this is a board level dependency, keep the R5 subsytem
> disabled at SoC dtsi, otherwise it results in probe errors like
> below during AM62P SK boot:
>
> r5fss@...00000: reserved memory init failed, ret = -22
> r5fss@...00000: k3_r5_cluster_rproc_init failed, ret = -22
> r5fss@...00000: reserved memory init failed, ret = -22
> r5fss@...00000: k3_r5_cluster_rproc_init failed, ret = -22

Shouldn't we have a similar patch for the am64 R5 cores?


>
> Fixes: b5080c7c1f7e ("arm64: dts: ti: k3-am62p: Add nodes for more IPs")
>
> Signed-off-by: Vaishnav Achath <vaishnav.a@...com>
> ---
>   arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi    | 2 ++
>   arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi | 1 +
>   2 files changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi
> index c4b0b91d70cf..14eb9ba836d3 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi
> @@ -187,6 +187,8 @@ mcu_r5fss0: r5fss@...00000 {
>   		ranges = <0x79000000 0x00 0x79000000 0x8000>,
>   			 <0x79020000 0x00 0x79020000 0x8000>;
>   		power-domains = <&k3_pds 7 TI_SCI_PD_EXCLUSIVE>;
> +		status = "disabled";
> +
>   		mcu_r5fss0_core0: r5f@...00000 {
>   			compatible = "ti,am62-r5f";
>   			reg = <0x79000000 0x00008000>,
> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
> index 19f42b39394e..10a7059b2d9b 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
> @@ -78,6 +78,7 @@ wkup_r5fss0: r5fss@...00000 {
>   		ranges = <0x78000000 0x00 0x78000000 0x8000>,
>   			 <0x78100000 0x00 0x78100000 0x8000>;
>   		power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>;
> +		status = "disabled";
>   
>   		wkup_r5fss0_core0: r5f@...00000 {
>   			compatible = "ti,am62-r5f";