linux-kernel - Re: [PATCH] dma-coherent: add support for multi coherent rmems per dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZbuETxd_MfFN45C8@smile.fi.intel.com>
Date: Thu, 1 Feb 2024 13:45:19 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Robin Murphy <robin.murphy@....com>
Cc: Howard Yen <howardyen@...gle.com>, hch@....de, m.szyprowski@...sung.com,
	gregkh@...uxfoundation.org, petr.tesarik.ext@...wei.com,
	rafael@...nel.org, broonie@...nel.org, james@...iv.tech,
	james.clark@....com, masahiroy@...nel.org,
	linux-kernel@...r.kernel.org, iommu@...ts.linux.dev
Subject: Re: [PATCH] dma-coherent: add support for multi coherent rmems per
 dev

On Thu, Feb 01, 2024 at 10:45:30AM +0000, Robin Murphy wrote:
> On 2024-02-01 9:35 am, Howard Yen wrote:

..

> >   	struct dma_coherent_mem	*dma_mem; /* internal for coherent mem
> >   					     override */
> > +	struct list_head	dma_mem_list;
> 
> I'm not necessarily against the idea, but only if it's implemented sensibly.
> If we're going to have a list of these it should *replace* the existing
> pointer, not do this weird thing with both.

+1 on the comment.

-- 
With Best Regards,
Andy Shevchenko