linux-kernel - Re: [PATCH v2 1/5] pwm: dwc: drop redundant error check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <qrwcje4t2pbbxilnlfz2q7njodcp6vl54uaypdbvjgvwhgvc5g@4eq5wvumpjjx>
Date: Thu, 8 Feb 2024 08:46:44 +0100
From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To: andriy.shevchenko@...ux.intel.com, Raag Jadav <raag.jadav@...el.com>
Cc: jarkko.nikula@...ux.intel.com, mika.westerberg@...ux.intel.com, 
	lakshmi.sowjanya.d@...el.com, linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/5] pwm: dwc: drop redundant error check

On Thu, Feb 08, 2024 at 12:35:25PM +0530, Raag Jadav wrote:
> pcim_iomap_table() fails only if pcim_iomap_regions() fails. No need to
> check for failure if the latter is already successful.

Is this really true? pcim_iomap_table() calls devres_alloc_node() which
might fail if the allocation fails. (Yes, I know
https://lwn.net/Articles/627419/, but the rule is still to check for
errors, right?)

What am I missing?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)