linux-kernel - Re: [PATCH v1 04/10] phy: rockchip: add usbdp combo phy driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 11 Feb 2024 21:45:04 +0100
From: Johan Jonker <jbx6244@...dex.com>
To: Sebastian Reichel <sebastian.reichel@...labora.com>,
 Heiko Stuebner <heiko@...ech.de>, Vinod Koul <vkoul@...nel.org>,
 Kishon Vijay Abraham I <kishon@...nel.org>,
 linux-rockchip@...ts.infradead.org, linux-phy@...ts.infradead.org
Cc: Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Frank Wang <frank.wang@...k-chips.com>,
 Kever Yang <kever.yang@...k-chips.com>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel@...labora.com,
 Zhang Yubing <yubing.zhang@...k-chips.com>
Subject: Re: [PATCH v1 04/10] phy: rockchip: add usbdp combo phy driver



On 2/9/24 19:17, Sebastian Reichel wrote:
> This adds a new USBDP combo PHY with Samsung IP block driver.
> 
> The driver get lane mux and mapping info in 2 ways, supporting
> DisplayPort alternate mode or parsing from DT. When parsing from DT,
> the property "rockchip,dp-lane-mux" provide the DP mux and mapping
> info. This is needed when the PHY is not used with TypeC Alt-Mode.
> For example if the USB3 interface of the PHY is connected to a USB
> Type A connector and the DP interface is connected to a DisplayPort
> connector.
> 
> When do DP link training, need to set lane number, link rate, swing,
> and pre-emphasis via PHY configure interface.
> 
> Co-developed-by: Heiko Stuebner <heiko@...ech.de>
> Signed-off-by: Heiko Stuebner <heiko@...ech.de>
> Co-developed-by: Zhang Yubing <yubing.zhang@...k-chips.com>
> Signed-off-by: Zhang Yubing <yubing.zhang@...k-chips.com>
> Co-developed-by: Frank Wang <frank.wang@...k-chips.com>
> Signed-off-by: Frank Wang <frank.wang@...k-chips.com>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.com>
> ---

For Linux FTRACE filters it is needed that all functions in a driver start with the same function prefix.
Currently there's a mix of udphy_* and rockchip_*
Maybe use rk_udphy_* ??? similar to for example rk_nfc_* in rockchip-nand-controller.c

Johan