linux-kernel - Re: [PATCH] powerpc/iommu: Fix the missing iommu_group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0abafe3e-7dfd-4067-8a47-fa8eea00b232@linux.ibm.com>
Date: Wed, 14 Feb 2024 23:43:28 +0530
From: Shivaprasad G Bhat <sbhat@...ux.ibm.com>
To: Jason Gunthorpe <jgg@...pe.ca>
Cc: Venkat Rao Bagalkote <venkat88@...ux.vnet.ibm.com>, iommu@...ts.linux.dev,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        npiggin@...il.com, christophe.leroy@...roup.eu,
        aneesh.kumar@...nel.org, naveen.n.rao@...ux.ibm.com, jroedel@...e.de,
        tpearson@...torengineering.com, aik@....com, bgray@...ux.ibm.com,
        gregkh@...uxfoundation.org, gbatra@...ux.vnet.ibm.com,
        vaibhav@...ux.ibm.com, Michael Ellerman <mpe@...erman.id.au>
Subject: Re: [PATCH] powerpc/iommu: Fix the missing iommu_group_put() during
 platform domain attach


On 2/14/24 18:28, Jason Gunthorpe wrote:
> On Wed, Feb 14, 2024 at 11:53:20PM +1100, Michael Ellerman wrote:
>> Venkat Rao Bagalkote <venkat88@...ux.vnet.ibm.com> writes:
>>> Thanks for the patch. Applied this patch and verified and issue is fixed.
>>>
>>> This issue way originally reported in the below mail.
>>>
>>> https://marc.info/?l=linux-kernel&m=170737160630106&w=2
>> Please use lore for links, in this case:
>>
>> https://lore.kernel.org/all/274e0d2b-b5cc-475e-94e6-8427e88e271d@linux.vnet.ibm.com/
> Also if you are respinning you may prefer this
>
> @@ -1285,14 +1285,15 @@ spapr_tce_platform_iommu_attach_dev(struct iommu_domain *platform_domain,
>                                      struct device *dev)
>   {
>          struct iommu_domain *domain = iommu_get_domain_for_dev(dev);
> -       struct iommu_group *grp = iommu_group_get(dev);
>          struct iommu_table_group *table_group;
> +       struct iommu_group *grp;
>          int ret = -EINVAL;
>   
>          /* At first attach the ownership is already set */
>          if (!domain)
>                  return 0;
>   
> +       grp = iommu_group_get(dev);
>          if (!grp)
>                  return -ENODEV;
>
> Which is sort of why this happened in the first place :)

Right! Posted the v2 here

https://lore.kernel.org/linux-iommu/170793401503.7491.9431631474642074097.stgit@linux.ibm.com/


Thanks,

Shivaprasad

> Jason