linux-kernel - Re: [PATCH 2/4] arm64: dts: mediatek: mt8195: Add missing gce-client-reg to vpp/vdosys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 1 Mar 2024 09:39:07 -0500
From: Nícolas F. R. A. Prado <nfraprado@...labora.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: Matthias Brugger <matthias.bgg@...il.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Allen-KH Cheng <allen-kh.cheng@...iatek.com>,
	Tinghan Shen <tinghan.shen@...iatek.com>,
	"Jason-JH.Lin" <jason-jh.lin@...iatek.com>,
	"Nancy.Lin" <nancy.lin@...iatek.com>, kernel@...labora.com,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 2/4] arm64: dts: mediatek: mt8195: Add missing
 gce-client-reg to vpp/vdosys

On Fri, Mar 01, 2024 at 09:50:31AM +0100, AngeloGioacchino Del Regno wrote:
> Il 29/02/24 20:44, Nícolas F. R. A. Prado ha scritto:
> > Add the missing mediatek,gce-client-reg property to the vppsys and
> > vdosys nodes to allow them to use the GCE. This prevents the "can't
> > parse gce-client-reg property" error from being printed and should
> > result in better performance.
> > 
> > Fixes: 6aa5b46d1755 ("arm64: dts: mt8195: Add vdosys and vppsys clock nodes")
> > Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
> 
> Can you please squash patches 2,3,4 in a single one?
> 
> It doesn't make a lot of sense to have them separated in this case, only
> generates commit noise for no practical reason imo.
> 
> arm64: dts: mediatek: mt8195: Add missing gce-client-reg to vpp/vdo/mutex

I split them like this so that each has its own fixes tag and can all be easily
backported (as mentioned in the cover letter). That said, the commits fixed in 2
and 3 both landed in v6.1-rc1, so they could be squashed and still easily
backported. But the commit fixed in patch 4 only landed in v6.4-rc1, so if we
squash them all together, the first two won't be backported to v6.1.

Let me know how you want to proceed.

Thanks,
Nícolas