linux-kernel - Re: [PATCH v9 2/3] clocksource: Add JH7110 timer driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240319-vivacious-anointer-cf790d8852c1@spud>
Date: Tue, 19 Mar 2024 08:19:04 +0000
From: Conor Dooley <conor@...nel.org>
To: Ziv Xu <ziv.xu@...rfivetech.com>
Cc: Daniel Lezcano <daniel.lezcano@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Emil Renner Berthing <emil.renner.berthing@...onical.com>,
	Christophe JAILLET <christophe.jaillet@...adoo.fr>,
	linux-riscv@...ts.infradead.org, devicetree@...r.kernel.org,
	Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Walker Chen <walker.chen@...rfivetech.com>,
	Xingyu Wu <xingyu.wu@...rfivetech.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v9 2/3] clocksource: Add JH7110 timer driver

On Mon, Mar 18, 2024 at 11:06:48AM +0800, Ziv Xu wrote:

> +static int jh7110_timer_start(struct jh7110_clkevt *clkevt)
> +{
> +	int ret;
> +
> +	/* Disable and clear interrupt first */
> +	writel(JH7110_TIMER_INT_DIS, clkevt->base + JH7110_TIMER_INT_MASK);
> +	ret = jh7110_timer_int_clear(clkevt);

The return value here is not checked/used.

> +	writel(JH7110_TIMER_INT_ENA, clkevt->base + JH7110_TIMER_INT_MASK);
> +	writel(JH7110_TIMER_ENA, clkevt->base + JH7110_TIMER_ENABLE);
> +
> +	return 0;
> +}

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)