[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
<NTZPR01MB098638E8E9C1199AF8E5FAE2E133A@NTZPR01MB0986.CHNPR01.prod.partner.outlook.cn>
Date: Wed, 20 Mar 2024 01:40:31 +0000
From: Ziv Xu <ziv.xu@...rfivetech.com>
To: Conor Dooley <conor@...nel.org>
CC: Daniel Lezcano <daniel.lezcano@...aro.org>, Thomas Gleixner
<tglx@...utronix.de>, Emil Renner Berthing
<emil.renner.berthing@...onical.com>, Christophe JAILLET
<christophe.jaillet@...adoo.fr>, "linux-riscv@...ts.infradead.org"
<linux-riscv@...ts.infradead.org>, "devicetree@...r.kernel.org"
<devicetree@...r.kernel.org>, Rob Herring <robh+dt@...nel.org>, Krzysztof
Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Paul Walmsley
<paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, Albert Ou
<aou@...s.berkeley.edu>, Philipp Zabel <p.zabel@...gutronix.de>, Walker Chen
<walker.chen@...rfivetech.com>, Xingyu Wu <xingyu.wu@...rfivetech.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject:
回复: [PATCH v9 2/3] clocksource: Add JH7110 timer driver
> On Mon, Mar 18, 2024 at 11:06:48AM +0800, Ziv Xu wrote:
>
> > +static int jh7110_timer_start(struct jh7110_clkevt *clkevt) {
> > + int ret;
> > +
> > + /* Disable and clear interrupt first */
> > + writel(JH7110_TIMER_INT_DIS, clkevt->base +
> JH7110_TIMER_INT_MASK);
> > + ret = jh7110_timer_int_clear(clkevt);
>
> The return value here is not checked/used.
>
I will change it in the next version,thanks.
Best regards
Ziv.xu
> > + writel(JH7110_TIMER_INT_ENA, clkevt->base +
> JH7110_TIMER_INT_MASK);
> > + writel(JH7110_TIMER_ENA, clkevt->base + JH7110_TIMER_ENABLE);
> > +
> > + return 0;
> > +}
Powered by blists - more mailing lists