[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a9a84b30-838f-41e6-8faf-b3508d1ba263@gmail.com>
Date: Mon, 25 Mar 2024 20:30:48 +0800
From: Alex Shi <seakeel@...il.com>
To: Matthew Wilcox <willy@...radead.org>, alexs@...nel.org
Cc: Andrea Arcangeli <aarcange@...hat.com>,
Izik Eidus <izik.eidus@...ellosystems.com>, david@...hat.com,
Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
linux-kernel@...r.kernel.org, Hugh Dickins <hughd@...gle.com>,
Chris Wright <chrisw@...s-sol.org>
Subject: Re: [PATCH v2 05/14] mm/ksm: use folio in stable_node_dup
On 3/22/24 11:57 PM, Matthew Wilcox wrote:
> On Fri, Mar 22, 2024 at 04:36:52PM +0800, alexs@...nel.org wrote:
>> -static struct page *stable_node_dup(struct ksm_stable_node **_stable_node_dup,
>> - struct ksm_stable_node **_stable_node,
>> - struct rb_root *root,
>> - bool prune_stale_stable_nodes)
>> +static void *stable_node_dup(struct ksm_stable_node **_stable_node_dup,
>> + struct ksm_stable_node **_stable_node,
>> + struct rb_root *root,
>> + bool prune_stale_stable_nodes)
>
> Do we really have to go through this void * stage?
Hi Willy,
Thank a lot for reminder. Yes, we could keep the 'struct page*' return value here.
And so we don't need to change indent here.
Thanks!
>
> Also, please stop reindenting the arguments. I tend to just switch to
> two tabs, but lining them up with the opening bracket leads to extra
> churn. Either leave them alone for the entire series or switch _once_.
>
Powered by blists - more mailing lists