linux-kernel - Re: [PATCH 01/26] cifs: Fix duplicate fscache cookie warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 15 Apr 2024 17:51:30 -0500
From: Steve French <smfrench@...il.com>
To: David Howells <dhowells@...hat.com>
Cc: Jeff Layton <jlayton@...nel.org>, Christian Brauner <christian@...uner.io>, 
	Gao Xiang <hsiangkao@...ux.alibaba.com>, Dominique Martinet <asmadeus@...ewreck.org>, 
	Matthew Wilcox <willy@...radead.org>, Marc Dionne <marc.dionne@...istor.com>, 
	Paulo Alcantara <pc@...guebit.com>, Shyam Prasad N <sprasad@...rosoft.com>, Tom Talpey <tom@...pey.com>, 
	Eric Van Hensbergen <ericvh@...nel.org>, Ilya Dryomov <idryomov@...il.com>, netfs@...ts.linux.dev, 
	linux-cachefs@...hat.com, linux-afs@...ts.infradead.org, 
	linux-cifs@...r.kernel.org, linux-nfs@...r.kernel.org, 
	ceph-devel@...r.kernel.org, v9fs@...ts.linux.dev, 
	linux-erofs@...ts.ozlabs.org, linux-fsdevel@...r.kernel.org, 
	linux-mm@...ck.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Steve French <sfrench@...ba.org>, Shyam Prasad N <nspmangalore@...il.com>, 
	Rohith Surabattula <rohiths.msft@...il.com>
Subject: Re: [PATCH 01/26] cifs: Fix duplicate fscache cookie warnings

Should this be merged independently (and sooner? in rc5?)

On Mon, Apr 15, 2024 at 8:04 AM David Howells <dhowells@...hat.com> wrote:
>
> Jeff Layton <jlayton@...nel.org> wrote:
>
> > > +struct cifs_fscache_inode_key {
> > > +
> > > +   __le64  uniqueid;       /* server inode number */
> > > +   __le64  createtime;     /* creation time on server */
> > > +   u8      type;           /* S_IFMT file type */
> > > +} __packed;
> > > +
> >
> > Interesting. So the uniqueid of the inode is not unique within the fs?
> > Or are the clients are mounting shares that span multiple filesystems?
> > Or, are we looking at a situation where the uniqueid is being quickly
> > reused for new inodes after the original inode is unlinked?
>
> The problem is that it's not unique over time.  creat(); unlink(); creat();
> may yield a repeat of the uniqueid.  It's like i_ino in that respect.
>
> David
>


-- 
Thanks,

Steve