linux-kernel - Re: [PATCH 2/2] eeprom: 93xx46: drop unneeded MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6599e2a3-3b04-4ea2-aa5c-a916b66c8009@kernel.org>
Date: Wed, 8 May 2024 20:15:00 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: Arnd Bergmann <arnd@...db.de>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Miquel Raynal <miquel.raynal@...tlin.com>,
 Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>,
 linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org
Subject: Re: [PATCH 2/2] eeprom: 93xx46: drop unneeded MODULE_ALIAS

On 08/05/2024 19:53, Andy Shevchenko wrote:
> On Sun, Apr 14, 2024 at 05:49:57PM +0200, Krzysztof Kozlowski wrote:
>> The ID table already has respective entry and MODULE_DEVICE_TABLE and
>> creates proper alias for SPI driver.  Having another MODULE_ALIAS causes
>> the alias to be duplicated.
> 
> ...
> 
>>  MODULE_ALIAS("spi:93xx46");
> 
> I was stumbled over this (leftover?).
> Commit message doesn't elaborate this bit.
> Any comments?

It is not present in ID table and commit msg removes only duplicated
aliases. That alias has meaning - someone might be actually relying on it.

Best regards,
Krzysztof