linux-kernel - Re: [PATCH 02/13] dt-bindings: thead: add a vlen register length property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 10 Jun 2024 00:27:09 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Charlie Jenkins <charlie@...osinc.com>
Cc: Palmer Dabbelt <palmer@...belt.com>, linux-riscv@...ts.infradead.org, 
 Jisheng Zhang <jszhang@...nel.org>, linux-kselftest@...r.kernel.org, 
 Samuel Holland <samuel@...lland.org>, 
 Paul Walmsley <paul.walmsley@...ive.com>, Jonathan Corbet <corbet@....net>, 
 Albert Ou <aou@...s.berkeley.edu>, Conor Dooley <conor@...nel.org>, 
 linux-kernel@...r.kernel.org, Andy Chiu <andy.chiu@...ive.com>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>, 
 Shuah Khan <shuah@...nel.org>, linux-sunxi@...ts.linux.dev, 
 devicetree@...r.kernel.org, Jernej Skrabec <jernej.skrabec@...il.com>, 
 Evan Green <evan@...osinc.com>, linux-doc@...r.kernel.org, 
 Guo Ren <guoren@...nel.org>
Subject: Re: [PATCH 02/13] dt-bindings: thead: add a vlen register length
 property


On Sun, 09 Jun 2024 21:45:07 -0700, Charlie Jenkins wrote:
> Add a property analogous to the vlenb CSR so that software can detect
> the vector length of each CPU prior to it being brought online.
> Currently software has to assume that the vector length read from the
> boot CPU applies to all possible CPUs. On T-Head CPUs implementing
> pre-ratification vector, reading the th.vlenb CSR may produce an illegal
> instruction trap, so this property is required on such systems.
> 
> Signed-off-by: Charlie Jenkins <charlie@...osinc.com>
> ---
>  Documentation/devicetree/bindings/riscv/thead.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/riscv/thead.yaml: 'thead,vlenb' is not one of ['$id', '$schema', 'title', 'description', 'examples', 'required', 'allOf', 'anyOf', 'oneOf', 'definitions', '$defs', 'additionalProperties', 'dependencies', 'dependentRequired', 'dependentSchemas', 'patternProperties', 'properties', 'not', 'if', 'then', 'else', 'unevaluatedProperties', 'deprecated', 'maintainers', 'select', '$ref']
	from schema $id: http://devicetree.org/meta-schemas/base.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240609-xtheadvector-v1-2-3fe591d7f109@rivosinc.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.