[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5ad5cf7a-c5c6-449e-9ed9-3d9f74959a19@linaro.org>
Date: Mon, 10 Jun 2024 16:58:21 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Judith Mendez <jm@...com>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, William Breathitt Gray <wbg@...nel.org>,
Nishanth Menon <nm@...com>
Cc: linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, Vignesh Raghavendra <vigneshr@...com>,
Tero Kristo <kristo@...nel.org>, linux-arm-kernel@...ts.infradead.org,
David Lechner <david@...hnology.com>
Subject: Re: [PATCH v4 1/8] dt-bindings: counter: Add new ti,am62-eqep
compatible
On 10/06/2024 16:46, Judith Mendez wrote:
> Add new compatible ti,am62-eqep for TI K3 devices. If a device
> uses this compatible, require power-domains property.
>
> Since there is only one functional and interface clock for eqep,
> clock-names is not really required, so removed from required
> section, make it optional for ti,am3352-eqep compatible, and
> update the example.
>
...
> interrupts = <79>;
> };
>
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/soc/ti,sci_pm_domain.h>
> +
> + bus {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + eqep1: counter@...10000 {
No need for label
> + compatible = "ti,am62-eqep";
> + reg = <0x00 0x23210000 0x00 0x100>;
> + power-domains = <&k3_pds 60 TI_SCI_PD_EXCLUSIVE>;
> + clocks = <&k3_clks 60 0>;
> + interrupts = <GIC_SPI 117 IRQ_TYPE_EDGE_RISING>;
> + status = "disabled";
Drop... which also points to another comment - since this was no-op and
example is basically the same, then just don't add it. No point.
> + };
> + };
> ...
Best regards,
Krzysztof
Powered by blists - more mailing lists