linux-kernel - Re: [PATCH] KVM: x86/tdp_mmu: Sprinkle __must

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4552458c1441e3805868fbcf3e95bee4b0d1f2d9.camel@intel.com>
Date: Tue, 11 Jun 2024 09:41:14 +0000
From: "Huang, Kai" <kai.huang@...el.com>
To: "kvm@...r.kernel.org" <kvm@...r.kernel.org>, "pbonzini@...hat.com"
	<pbonzini@...hat.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: "binbin.wu@...ux.intel.com" <binbin.wu@...ux.intel.com>, "Yamahata, Isaku"
	<isaku.yamahata@...el.com>
Subject: Re: [PATCH] KVM: x86/tdp_mmu: Sprinkle __must_check

On Tue, 2024-06-11 at 04:11 -0400, Paolo Bonzini wrote:
> From: Isaku Yamahata <isaku.yamahata@...el.com>
> 
> The TDP MMU function __tdp_mmu_set_spte_atomic uses a cmpxchg64 to replace
> the SPTE value and returns -EBUSY on failure.  The caller must check the
> return value and retry.  Add __must_check to it, as well as to two more
> functions that forward the return value of __tdp_mmu_set_spte_atomic to
> their caller.
> 
> Signed-off-by: Isaku Yamahata <isaku.yamahata@...el.com>
> Reviewed-by: Binbin Wu <binbin.wu@...ux.intel.com>
> Message-Id: <8f7d5a1b241bf5351eaab828d1a1efe5c17699ca.1705965635.git.isaku.yamahata@...el.com>
> Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>
> ---
> 

Acked-by: Kai Huang <kai.huang@...el.com>