linux-kernel - Re: [PATCH 3/5] clk: qcom: dispcc-sm8650: drop TCXO from table when using rcg2_shared

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <754a6ad5-f093-4426-9d68-3556978e1d2a@linaro.org>
Date: Mon, 24 Jun 2024 09:56:33 +0200
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Konrad Dybcio <konrad.dybcio@...aro.org>,
 Bjorn Andersson <andersson@...nel.org>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Taniya Das <quic_tdas@...cinc.com>
Cc: linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] clk: qcom: dispcc-sm8650: drop TCXO from table when
 using rcg2_shared_ops

On 22/06/2024 13:01, Konrad Dybcio wrote:
> On 21.06.2024 4:01 PM, Neil Armstrong wrote:
>> Since those clocks are using rcg2_shared_ops to park on TCXO
>> instead of disable, no need to have TCXO in the frequency table.
>>
>> Fixes: 9e939f008338 ("clk: qcom: add the SM8650 Display Clock Controller driver")
>> Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org>
>> ---
> 
> I don't think that's correct.. some hardware can still run with the
> core clock @ 19.2 / 38.4 MHz

I agree, but the same table on other dispcc drivers don't have this TCXO entries,
and the OPP table in DT neither...

I'll drop this, but at some point we should align ourselves.

Neil

> 
> Konrad