linux-kernel - Re: [PATCH v5] PCI: keystone: Add workaround for Errata #i2037 (AM65x SR 1.0)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240628211958.GA2213719@rocinante>
Date: Sat, 29 Jun 2024 06:19:58 +0900
From: Krzysztof Wilczyński <kw@...ux.com>
To: Jan Kiszka <jan.kiszka@...mens.com>
Cc: Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
	Kishon Vijay Abraham I <kishon@...nel.org>,
	Siddharth Vadapalli <s-vadapalli@...com>,
	Vignesh Raghavendra <vigneshr@...com>, Nishanth Menon <nm@...com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v5] PCI: keystone: Add workaround for Errata #i2037
 (AM65x SR 1.0)

Hello,

> Errata #i2037 in AM65x/DRA80xM Processors Silicon Revision 1.0
> (SPRZ452D_July 2018_Revised December 2019 [1]) mentions when an
> inbound PCIe TLP spans more than two internal AXI 128-byte bursts,
> the bus may corrupt the packet payload and the corrupt data may
> cause associated applications or the processor to hang.
> 
> The workaround for Errata #i2037 is to limit the maximum read
> request size and maximum payload size to 128 bytes. Add workaround
> for Errata #i2037 here. The errata and workaround is applicable
> only to AM65x SR 1.0 and later versions of the silicon will have
> this fixed.
> 
> [1] -> https://www.ti.com/lit/er/sprz452i/sprz452i.pdf

Jan, thank you for picking up this patch.  Siddharth, thank you for being
very thorough, chasing after old review comments to be addressed.

Much appreciated on both accounts!

	Krzysztof