linux-kernel - Re: [PATCH 1/1] slimbus: Fix struct and documentation alignment in stream.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024070532-romp-clarify-7d2b@gregkh>
Date: Fri, 5 Jul 2024 09:53:57 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: srinivas.kandagatla@...aro.org
Cc: linux-kernel@...r.kernel.org, Amit Vadhavana <av2082000@...il.com>,
	"Ricardo B . Marliere" <ricardo@...liere.net>
Subject: Re: [PATCH 1/1] slimbus: Fix struct and documentation alignment in
 stream.c

On Fri, Jul 05, 2024 at 08:40:40AM +0100, srinivas.kandagatla@...aro.org wrote:
> From: Amit Vadhavana <av2082000@...il.com>
> 
> The placement of the `segdist_codes` array documentation was corrected
> to conform with kernel documentation guidelines. The `@...dist_codes`
> was placed incorrectly within the struct `segdist_code` documentation
> block, which led to a potential misinterpretation of the code structure.
> 
> The `segdist_codes` array documentation was moved outside the struct
> block, and a separate comment block was provided for it. This change
> ensures that clarity and proper alignment with kernel documentation
> standards are maintained.
> 
> A kernel-doc warning was addressed:
>     ./drivers/slimbus/stream.c:49: warning: Excess struct member 'segdist_codes' description in 'segdist_code'
> 
> Signed-off-by: Amit Vadhavana <av2082000@...il.com>
> Reviewed-by: Ricardo B. Marliere <ricardo@...liere.net>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> ---
>  drivers/slimbus/stream.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

I don't think this was ment to be sent as part of the fastrpc patch
series :(

Can you fix this up and resend a v2?

thanks,

greg k-h