linux-kernel - Re: [PATCH V3 0/2] Add support for Awinic SAR sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <pndbk32vnhz.fsf@axis.com>
Date: Fri, 12 Jul 2024 13:49:28 +0200
From: Waqar Hameed <waqar.hameed@...s.com>
To: <wangshuaijie@...nic.com>
CC: <jic23@...nel.org>, <lars@...afoo.de>, <robh@...nel.org>,
	<krzk+dt@...nel.org>, <conor+dt@...nel.org>, <linux-iio@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<liweilei@...nic.com>, <kangjiajun@...nic.com>
Subject: Re: [PATCH V3 0/2] Add support for Awinic SAR sensor

On Fri, Jul 12, 2024 at 11:31 +0000 wangshuaijie@...nic.com wrote:

> From: shuaijie wang <wangshuaijie@...nic.com>
>
> Add drivers that support Awinic SAR (Specific Absorption Rate)
> sensors to the Linux kernel.
>
> The AW9610X series and AW963XX series are high-sensitivity
> capacitive proximity detection sensors.
>
> This device detects human proximity and assists electronic devices
> in reducing SAR to pass SAR related certifications.
>
> The device reduces RF power and reduces harm when detecting human proximity.
> Increase power and improve signal quality when the human body is far away.
>
> This patch implements device initialization, registration,
> I/O operation handling and interrupt handling, and passed basic testing.
>
> shuaijie wang (2):
>   dt-bindings: iio: Add YAML to Awinic proximity sensor
>   Add support for Awinic proximity sensor
>
>  .../iio/proximity/awinic,aw96xxx.yaml         |  127 ++
>  drivers/iio/proximity/Kconfig                 |   10 +
>  drivers/iio/proximity/Makefile                |    2 +
>  drivers/iio/proximity/aw9610x.c               | 1150 ++++++++++
>  drivers/iio/proximity/aw963xx.c               | 1371 ++++++++++++
>  drivers/iio/proximity/aw_sar.c                | 1850 +++++++++++++++++
>  drivers/iio/proximity/aw_sar.h                |   23 +
>  drivers/iio/proximity/aw_sar_comm_interface.c |  550 +++++
>  drivers/iio/proximity/aw_sar_comm_interface.h |  172 ++
>  drivers/iio/proximity/aw_sar_type.h           |  371 ++++
>  10 files changed, 5626 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/proximity/awinic,aw96xxx.yaml
>  create mode 100644 drivers/iio/proximity/aw9610x.c
>  create mode 100644 drivers/iio/proximity/aw963xx.c
>  create mode 100644 drivers/iio/proximity/aw_sar.c
>  create mode 100644 drivers/iio/proximity/aw_sar.h
>  create mode 100644 drivers/iio/proximity/aw_sar_comm_interface.c
>  create mode 100644 drivers/iio/proximity/aw_sar_comm_interface.h
>  create mode 100644 drivers/iio/proximity/aw_sar_type.h
>
>
> base-commit: 43db1e03c086ed20cc75808d3f45e780ec4ca26e

This is version 3, but I cannot see a description of the incremental
changes between the versions (or links) in this cover letter. It will
therefore make it harder to review...

It also looks like the _actual_ commit messages in the patch series have
some kind of description of the changes from previous versions. That is
also not correct. Please read
https://docs.kernel.org/process/submitting-patches.html#respond-to-review-comments
and
https://docs.kernel.org/process/submitting-patches.html#the-canonical-patch-format