linux-kernel - Re: [PATCH RESEND v9 0/2] Add support for Loongson1 APB DMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <84d2591b-4336-453f-bcb2-a7c47df0574c@app.fastmail.com>
Date: Wed, 17 Jul 2024 22:20:01 +0800
From: "Jiaxun Yang" <jiaxun.yang@...goat.com>
To: "Huacai Chen" <chenhuacai@...nel.org>
Cc: "Kelvin Cheung" <keguang.zhang@...il.com>,
 "Vinod Koul" <vkoul@...nel.org>, "Rob Herring" <robh@...nel.org>,
 "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
 "Conor Dooley" <conor+dt@...nel.org>,
 "Krzysztof Kozlowski" <krzk+dt@...nel.org>,
 "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
 dmaengine@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, "Conor Dooley" <conor.dooley@...rochip.com>
Subject: Re: [PATCH RESEND v9 0/2] Add support for Loongson1 APB DMA



在2024年7月17日七月 下午9:06，Huacai Chen写道：
> On Tue, Jul 16, 2024 at 9:12 PM Jiaxun Yang <jiaxun.yang@...goat.com> wrote:
>>
>>
>>
>> 在2024年7月16日七月 下午5:40，Huacai Chen写道：
>> > On Mon, Jul 15, 2024 at 3:00 PM Jiaxun Yang <jiaxun.yang@...goat.com> wrote:
>> >>
>> >>
>> >>
>> >> 在2024年7月15日七月 下午2:39，Huacai Chen写道：
>> >> [...]
>> >> >
>> >> >> You said that you've accepted my suggestion, which means you recognize
>> >> >> 'loongson' as the better name for the drivers.
>> >> > No, I don't think so, this is just a compromise to keep consistency.
>> >>
>> >> Folks, can we settle on this topic?
>> >>
>> >> Is this naming really important? As long as people can read actual chip name from
>> >> kernel code & documents, I think both are acceptable.
>> >>
>> >> I suggest let this patch go as is. And if anyone want to unify the naming, they can
>> >> propose a treewide patch.
>> > Renaming still breaks config files.
>>
>> This is trival with treewide sed :-)
> Please read the commit message of b8d3349803ba34afda429e87a837fd95a carefully.

We don't have 114 defconfigs don't we?

Those symbols are not frequently specified by down stream users either.

I think Keguang had tried his best on resolving all reasonable comments.

Naming is a matter of preference after all, I think we should give Keguang some respect
here.

Thanks
- Jiaxun

>
> Huacai
>
>>
>> Thanks
>> - Jiaxun
>>
>> --
>> - Jiaxun

-- 
- Jiaxun