linux-kernel - Re: [PATCH] sched/deadline: Fix imbalanced task reference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ae6fa16-80d3-4478-baae-b5bc06531e0c@huawei.com>
Date: Wed, 7 Aug 2024 17:39:44 +0800
From: Zhang Qiao <zhangqiao22@...wei.com>
To: Juri Lelli <juri.lelli@...hat.com>
CC: Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>,
	Vincent Guittot <vincent.guittot@...aro.org>, Dietmar Eggemann
	<dietmar.eggemann@....com>, Steven Rostedt <rostedt@...dmis.org>, Ben Segall
	<bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>, Valentin Schneider
	<vschneid@...hat.com>, <linux-kernel@...r.kernel.org>, Wander Costa
	<wcosta@...hat.com>
Subject: Re: [PATCH] sched/deadline: Fix imbalanced task reference



Hi,
在 2024/8/7 17:00, Juri Lelli 写道:
> Hi,
> 
> On 07/08/24 16:30, Zhang Qiao wrote:
>> When starting a deadline inactive_timer, the task_struct refs will
>> be incremented only if dl_server is not set. But when canceling the
>> inactive_timer, the task refs will be decremented whether dl_server is
>> set or not, leading to a task reference imbalance issue.
>>
>> This patch fixes the imbalanced reference by adding a '!dl_server()'
>> checker before calling put_task_struct().
>>
>> Fixes: 63ba8422f876 ("sched/deadline: Introduce deadline servers")
>> Signed-off-by: Zhang Qiao <zhangqiao22@...wei.com>
> 
> Isn't this equivalent to Wander's patch below?
> 

Yeah, i didn't notice it.

> https://lore.kernel.org/lkml/20240724142253.27145-3-wander@redhat.com/
> 



Thanks,
Zhang Qiao.
> Thanks,
> Juri
> 
> 
>