linux-kernel - Re: [PATCH] dt-bindings: timer: nxp,lpc3220-timer: Convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4a946758-f962-41af-a1e9-1bdeabe053ba@kernel.org>
Date: Wed, 7 Aug 2024 11:45:55 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Vladimir Zapolskiy <vz@...ia.com>,
 Animesh Agarwal <animeshagarwal28@...il.com>
Cc: Daniel Baluta <daniel.baluta@....com>,
 Daniel Lezcano <daniel.lezcano@...aro.org>,
 Thomas Gleixner <tglx@...utronix.de>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: timer: nxp,lpc3220-timer: Convert to
 dtschema

On 07/08/2024 10:41, Vladimir Zapolskiy wrote:
> On 8/7/24 09:01, Krzysztof Kozlowski wrote:
>> On 06/08/2024 22:13, Vladimir Zapolskiy wrote:
>>>> +
>>>> +  reg:
>>>> +    maxItems: 1
>>>> +
>>>> +  interrupts:
>>>> +    maxItems: 1
>>>> +
>>>> +  clocks:
>>>> +    maxItems: 1
>>>> +
>>>> +  clock-names:
>>>> +    const: timerclk
>>>> +
>>>> +  resets:
>>>> +    maxItems: 1
>>>> +
>>>> +required:
>>>> +  - compatible
>>>> +  - reg
>>>> +  - interrupts
>>>> +  - clocks
>>>> +  - clock-names
>>>
>>> Since there is always just a single supply clock, there is no need to
>>> specify "clock-names" as a required one, please change it.
>>
>> ??? That's a conversion. Why do you expect changing several DTS files
>> and maybe also driver? That's not needed for conversion. No.
> 
> I do not expect changing any DTS files, why? But I would be glad to see that
> the clock-names property becomes optional in the first place and therefore
> before the conversion.

OK, DTS does not have to be changed, but:
1. Old binding said it is required.
2. Kernel depends on this being required.

Best regards,
Krzysztof