linux-kernel - Re: [PATCH v3 4/8] arm64: dts: renesas: r9a09g057: Add RIIC0-RIIC8 nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWQodA1NdmCEXmW7UYjAbdLFP-YS=rnKffHbEP7zH+ErQ@mail.gmail.com>
Date: Mon, 26 Aug 2024 14:17:51 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Prabhakar <prabhakar.csengg@...il.com>
Cc: Magnus Damm <magnus.damm@...il.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	linux-renesas-soc@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Biju Das <biju.das.jz@...renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH v3 4/8] arm64: dts: renesas: r9a09g057: Add RIIC0-RIIC8 nodes

Hi Prabhakar,

On Wed, Aug 21, 2024 at 10:56 AM Prabhakar <prabhakar.csengg@...il.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
>
> Add RIIC0-RIIC8 nodes to RZ/V2H(P) ("R9A09G057") SoC DTSI.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> ---
> v2->v3
> - Grouped the I2C nodes
> - Dropped clock-frequency
> - Updated I2C nodes to match with the coding-style of DTS

Thanks for the update!

> --- a/arch/arm64/boot/dts/renesas/r9a09g057.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a09g057.dtsi
> @@ -201,6 +201,195 @@ ostm3: timer@...01000 {
>                         status = "disabled";
>                 };
>
> +               i2c8: i2c@...01000 {

Usually we sort the instances within a group by instance number, i.e.

    i2c0: i2c@...00400 {
    i2c1: i2c@...00800 {
    i2c2: i2c@...00c00 {
    i2c3: i2c@...01000 {
    i2c4: i2c@...01400 {
    i2c5: i2c@...01800 {
    i2c6: i2c@...01c00 {
    i2c7: i2c@...02000 {
    i2c8: i2c@...01000 {

See e.g. the scif nodes in arch/arm64/boot/dts/renesas/r8a77951.dtsi:

    scif0: serial@...60000 {
    scif1: serial@...68000 {
    scif2: serial@...88000 {
    scif3: serial@...50000 {
    scif4: serial@...40000 {
    scif5: serial@...30000 {

scif3 and scif4 have lower base addresses than scif0.

The rest LGTM.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds