lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6e5588d9-c22c-4a94-afce-1274c888403e@sirena.org.uk>
Date: Wed, 28 Aug 2024 11:40:06 +0100
From: Mark Brown <broonie@...nel.org>
To: Dev Jain <dev.jain@....com>
Cc: shuah@...nel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kselftest@...r.kernel.org, Catalin.Marinas@....com,
	will@...nel.org, ryan.roberts@....com, Anshuman.Khandual@....com,
	aneesh.kumar@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests/arm64: Fix build warnings for abi

On Tue, Aug 27, 2024 at 10:48:51AM +0530, Dev Jain wrote:

> -		ksft_exit_fail_msg("PTRACE_TRACEME", strerror(errno));
> +		ksft_exit_fail_perror("PTRACE_TRACEME");
>  
>  	if (raise(SIGSTOP))
> -		ksft_exit_fail_msg("raise(SIGSTOP)", strerror(errno));
> +		ksft_exit_fail_perror("raise(SIGSTOP)");

The idea with these is to include the error code as well so adding the
%s would be better.

>  	for (i = 9; i < ARRAY_SIZE(gpr_in); i++) {
>  		if (gpr_in[i] != gpr_out[i]) {
> -			ksft_print_msg("%s SVE VL %d mismatch in GPR %d: %llx != %llx\n",
> +			ksft_print_msg("%s SVE VL %d mismatch in GPR %d: %lx != %lx\n",
>  				       cfg->name, sve_vl, i,
>  				       gpr_in[i], gpr_out[i]);
>  			errors++;

This is a different pattern of warning, it'd be easier to review if each
patch only followed one pattern.  There's no code overlap between the
changes.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ