linux-kernel - Re: [PATCH] selftests/arm64: Fix build warnings for abi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c808efdf-fc78-40c3-90bf-948f65a6d133@sirena.org.uk>
Date: Wed, 28 Aug 2024 12:01:33 +0100
From: Mark Brown <broonie@...nel.org>
To: Will Deacon <will@...nel.org>
Cc: Dev Jain <dev.jain@....com>, shuah@...nel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-kselftest@...r.kernel.org, Catalin.Marinas@....com,
	ryan.roberts@....com, Anshuman.Khandual@....com,
	aneesh.kumar@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests/arm64: Fix build warnings for abi

On Tue, Aug 27, 2024 at 01:33:47PM +0100, Will Deacon wrote:
> On Tue, Aug 27, 2024 at 10:48:51AM +0530, Dev Jain wrote:
> > A "%s" is missing in ksft_exit_fail_msg(); instead, use the newly
> > introduced ksft_exit_fail_perror(). Also, uint64_t corresponds to
> > unsigned 64-bit integer, so use %lx instead of %llx.

> What's wrong with using %llx for a uint64_t? I think that part of the
> code is fine as-is.

IIRC there's some printf format specifiers specific to uint64_t which
are probably a better choice here.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)